Skip to content

pythonPackages.arch: init at 4.11#80343

Closed
arnoldfarkas wants to merge 3 commits intoNixOS:masterfrom
WorldQuant:wq_arch
Closed

pythonPackages.arch: init at 4.11#80343
arnoldfarkas wants to merge 3 commits intoNixOS:masterfrom
WorldQuant:wq_arch

Conversation

@arnoldfarkas
Copy link
Copy Markdown
Contributor

@arnoldfarkas arnoldfarkas commented Feb 17, 2020

Motivation for this change

Packaging Python module 'arch' 4.11 in Nix, and also its missing dependency, namely 'property-cached' 1.6.3.
Please note that test case ipc_closed_handle of libuv is unstable, the relevant change is also submitted as a separate PR (#80341).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package labels Feb 17, 2020
@ofborg ofborg bot requested review from cstrahan and dotlambda February 17, 2020 09:52
@ofborg ofborg bot added 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Feb 17, 2020
jonringer
jonringer reviewed Feb 18, 2020
View reviewed changes
pkgs/development/libraries/libuv/default.nix
"threadpool_multiple_event_loops" # times out on slow machines
"get_passwd" # passed on NixOS but failed on other Linuxes
"tcp_writealot" # times out sometimes
"ipc_closed_handle" # times out
Copy link
Copy Markdown
Contributor

@jonringer jonringer Feb 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this causes a lot of rebuilds... 5000+

@FRidh
Copy link
Copy Markdown
Member

FRidh commented Feb 27, 2020

please get rid of these mass-rebuilding commits in PR's that don't need it.

@FRidh FRidh closed this Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@cstrahan cstrahan Awaiting requested review from cstrahan

@dotlambda dotlambda Awaiting requested review from dotlambda

1 more reviewer

@jonringer jonringer jonringer left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 501+ This PR causes many rebuilds on Darwin and should normally target the staging branches. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arnoldfarkas @FRidh @jonringer